pickuma.
Career Starter

Surviving Your First Code Review as a Junior Developer

What actually happens in your first code review, how to read harsh-sounding comments, and the habits that turn review from a gauntlet into the fastest way to level up.

7 min read

Your first pull request gets twenty-three comments. Most of them are short. A few have no punctuation. One just says “why?” with nothing else. If your stomach drops, that reaction is normal and it is also wrong. A code review with twenty-three comments is not a verdict on you. It is a senior engineer spending forty minutes reading your work line by line, which is more attention than most of your code will ever get again.

The gap between how reviews feel and what they are is the single biggest thing that trips up new developers. You read “this should be a constant” as an attack. The reviewer typed it in four seconds between meetings and has already forgotten it. Closing that gap is most of the job.

What a review comment actually means

Review comments come in roughly four flavors, and learning to sort them fast changes everything.

Blocking correctness issues. “This throws if items is empty.” These are real bugs. Fix them, no discussion needed unless you genuinely disagree about whether it’s a bug. These are the comments that justify the entire process — a reviewer caught a crash before your users did.

Convention and consistency. “We use camelCase for these.” or “Move this into the existing helper.” The codebase has patterns you haven’t absorbed yet. These feel nitpicky and they are also how a hundred-file codebase stays readable. Just apply them.

Design questions. “Why a new service here instead of extending the existing one?” The word “why” reads as hostile and almost never is. The reviewer wants your reasoning. Sometimes you have a good one and they didn’t see it. Sometimes you’ll realize halfway through typing your reply that they’re right. Both outcomes are wins.

Taste and suggestions. “nit: I’d probably extract this.” The nit: prefix is a gift — it means “non-blocking, take it or leave it.” You can push back on these freely, and you should sometimes, so the reviewer learns you have judgment.

The trap is treating all four categories the same — either fixing every taste comment as if it were a bug, or arguing every nit as if your honor is on the line. Sort first, then respond.

How to respond without making it worse

The written-text problem is brutal here. You can’t hear tone, you can’t see the reviewer shrug, and a one-word comment carries whatever emotion you project onto it. Three habits keep threads short and warm.

Reply to every comment, even with just a checkmark or “done.” Silence reads as “ignored” or “offended.” A reviewer scrolling a half-resolved PR can’t tell if you missed their comment or rejected it. Acknowledge each one. It takes seconds and it tells the reviewer you read their work.

When you disagree, lead with the constraint, not the defense. Compare “No, I did it this way on purpose” with “I went this way because the batch job calls this path 4,000 times a minute and the extra allocation showed up in profiling — happy to change it if there’s a cleaner option.” The second invites a conversation. The first ends one. You’re not defending your ego; you’re surfacing context the reviewer didn’t have.

When you’re wrong, say so plainly and move on. “Good catch, fixed” is a complete and excellent response. New developers sometimes over-apologize, writing a paragraph about how they should have caught it. Don’t. Everyone ships bugs. The mark of a strong junior is fixing them without drama.

There’s a deeper version of this skill: tracking patterns across reviews. If the same comment keeps coming back — “add a test for the error path,” “this name is vague” — that’s not three separate notes. That’s one lesson you haven’t internalized yet. Writing those down somewhere you’ll actually re-read them is what turns a year of reviews into a year of growth instead of the same review fifty times.

Notion

A running doc of recurring review feedback — naming habits, missing-test patterns, conventions you keep tripping on — turns scattered PR comments into a personal checklist you run before requesting review. The free plan covers a single-person knowledge base comfortably.

Free for personal use; paid plans from $10/user/mo

Try Notion

Affiliate link · We earn a commission at no cost to you.

Make your PR easy to review in the first place

Half of a smooth review happens before anyone comments. Reviewers are pattern-matching for risk, and a few habits dramatically lower the friction.

Keep the diff small. A 200-line PR gets a careful read. A 2,000-line PR gets a skim and a rubber stamp, which feels easier but means real bugs sail through. If your change is large, split it: one PR for the refactor, one for the new behavior. Reviewers can hold maybe a few hundred lines in their head at once, and past that the quality of attention drops off a cliff.

Write a description that answers “what” and “why.” The diff already shows what changed line by line; what it can’t show is why you made the call you made, what you considered and rejected, and what you want eyes on. Two or three sentences and a “I wasn’t sure about X — thoughts?” saves a full round-trip.

Review your own diff before requesting review. Open the PR, read it as if it’s someone else’s, and leave comments on your own questionable lines. You’ll catch the leftover console.log, the commented-out block, the function you renamed everywhere but one place. Every one of those you catch yourself is a comment a reviewer doesn’t have to write, and it builds a reputation for shipping clean work.

The mindset shift that makes all of this click: the reviewer is on your side. You are both trying to get correct, maintainable code into the codebase. They are not a gatekeeper grading you; they are a second pair of eyes you get for free. The developers who grow fastest are the ones who start asking for reviews earlier and more often, not the ones who hide their code until it’s perfect.

FAQ

How many comments on a PR is too many?+
There's no fixed number. A 23-comment review on a 50-line PR usually means a lot of small convention fixes, which is normal for your first weeks on a codebase. What matters is the ratio of blocking issues to nits — if most are nits and conventions, you're doing fine. If most are correctness bugs, slow down and review your own work harder before requesting review.
Should I push back on feedback I disagree with?+
Yes, when you have a real reason — lead with the constraint or context the reviewer may not have, and stay open to being wrong. Reviewers respect a junior who can defend a decision with evidence far more than one who silently complies with everything. Just pick your battles: argue design and correctness, let go of pure taste.
What if I don't understand a comment?+
Ask. 'Can you point me to an example of how we usually do this?' is a completely normal question and far better than guessing and getting it wrong on the next round. Reviewers would much rather explain once than re-review the same misunderstanding twice.

Your first reviews will feel like exams. Within a few months they’ll feel like conversations, and not long after that you’ll be the one leaving comments on someone else’s first PR — at which point you’ll remember exactly how those four-word comments land, and you’ll write them a little more kindly.

Related reading

See all Career Starter articles →

Get the best tools, weekly

One email every Friday. No spam, unsubscribe anytime.